Add hack for :placeholder-shown #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkrotoff
commented
May 14, 2020
| @@ -54,6 +54,9 @@ let ffgradienter = autoprefixer({ | |||
| let selectorer = autoprefixer({ | |||
| overrideBrowserslist: ['Chrome 25', 'Firefox > 17', 'IE 10', 'Edge 12'] | |||
| }) | |||
| let placeholderShowner = autoprefixer({ | |||
| overrideBrowserslist: ['IE >= 10'] | |||
There was a problem hiding this comment.
I'm not sure about that
tkrotoff
commented
May 14, 2020
| prefix([':placeholder-shown'], { | ||
| selector: true, | ||
| feature: 'css-placeholder-shown', | ||
| browsers |
There was a problem hiding this comment.
css-placeholder uses browsers: browsers.concat(['ie 10 old', 'ie 11 old', 'firefox 18 old']) here. I don't understand what is 'ie 10 old' vs 'ie 10'.
There was a problem hiding this comment.
On my machine it is:
[
'firefox 4', 'firefox 5', 'firefox 6',
'firefox 7', 'firefox 8', 'firefox 9',
'firefox 10', 'firefox 11', 'firefox 12',
'firefox 13', 'firefox 14', 'firefox 15',
'firefox 16', 'firefox 17', 'firefox 18',
'firefox 19', 'firefox 20', 'firefox 21',
'firefox 22', 'firefox 23', 'firefox 24',
'firefox 25', 'firefox 26', 'firefox 27',
'firefox 28', 'firefox 29', 'firefox 30',
'firefox 31', 'firefox 32', 'firefox 33',
'firefox 34', 'firefox 35', 'firefox 36',
'firefox 37', 'firefox 38', 'firefox 39',
'firefox 40', 'firefox 41', 'firefox 42',
'firefox 43', 'firefox 44', 'firefox 45',
'firefox 46', 'firefox 47', 'firefox 48',
'firefox 49', 'firefox 50', 'ie 10',
'ie 11', 'kaios 2.5'
]
There was a problem hiding this comment.
We use old postfix in flexbox and some other prefixes with 2 syntaxes for the same prefix
|
LGTM. I will try to review it deeply and release on weekend. |
|
Thanks. Released at 9.8. |
Dan503
pushed a commit
to Dan503/autoprefixer
that referenced
this pull request
Jul 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1311
Please review carefully, this is my first PR here.