fix: remove comments before parsing calc value #171
Conversation
Since 8.4.6, PostCSS stopped removing comments in declarations, because it sometimes produced the wrong CSS. postcss-calc can remove the comments safely because it only modifies the contents of function nodes.
| for (const node of nodes) { | ||
| if (node.type !== 'comment') { | ||
| if (node.type === 'function') { | ||
| node.nodes = removeComments(node.nodes); |
There was a problem hiding this comment.
I suppose there is no risk of stack overflow as people won't nest function that deeply.
There was a problem hiding this comment.
We can remove useful comments...
There was a problem hiding this comment.
The issue PostCSS had was with comments that replaced spaces:
margin: 10px/* comment */20px;that would become
margin:10px20px;I've had a look at postcss-discard-comment, and interestingly because it looks at node.raws, it would repair the CSS value that PostCSS parssed incorrectly! It's also true that discard-comments does not remove !important comments, so maybe to get comment removal right we would end up duplicating too much logic from postcss-discard-comments
There was a problem hiding this comment.
I don't mind this improvement, just weird regression and parsing... Let's merge
|
For context, this is the discussion for the PostCSS change postcss/postcss#1703 |
Since 8.4.6, PostCSS stopped removing comments in declarations,
because it sometimes produced the wrong CSS.
postcss-calc can remove the comments safely because it only
modifies the contents of function nodes.