Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lilconfig #253

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Update lilconfig #253

merged 1 commit into from
Nov 20, 2023

Conversation

antonk52
Copy link
Contributor

Hi, lilconfig maintainer here 馃憢

I have recently released a new major version that is fully compatible with how it is currently used.

Notable Changes

I've updated lilconfig library to v3. There were 2 breaking changes in the library that do not affect this package:

  • Dropped support for node v10 and v12
  • Searcher results are cached between calls to searcher.search() (by default)

I can see that postcss-load-config has node v14 as min supported version. And since searcher (lilconfig('postcss', options)) is created on every call to rc function the new cache functionality won't be leveraged as the cache is stored in the searcher which gets recreated on every call. Thus this update does not require any updates to the code.

Ideally we would also set cache: false to the searcher's option to skip unnecessary caching.

I only found two places where this package's function is called

  • postcss-cli doesn't seem to require any changes. Uses up to date version of this package.
  • gulp-postcss which uses an 3.0.0 older version of this package, current is 4.0.1.

Commit Message Summary (CHANGELOG)

update lilconfig to v3.0.0

Type

  • CI
  • Fix
  • Perf
  • Docs
  • Test
  • Chore
  • Style
  • Build
  • Feature
  • Refactor

SemVer

  • Fix (:label: Patch)
  • Feature (:label: Minor)
  • Breaking Change (:label: Major)

Issues

  • Fixes #1

Checklist

  • Lint and unit tests pass with my changes
  • I have added tests that prove my fix is effective/works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes are merged and published in downstream modules

@ai ai merged commit 9a98c91 into postcss:main Nov 20, 2023
6 checks passed
@ai
Copy link
Member

ai commented Nov 20, 2023

Thanks. Released in 4.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants