Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support loading esm and ts files from json config #254

Merged
merged 4 commits into from Nov 30, 2023
Merged

feat: support loading esm and ts files from json config #254

merged 4 commits into from Nov 30, 2023

Conversation

brc-dd
Copy link
Contributor

@brc-dd brc-dd commented Nov 30, 2023

Notable Changes

Commit Message Summary (CHANGELOG)

Added support for loading .js, .mjs, .cjs, .ts, .mts, .cts files from JSON config.

Type

  • CI
  • Fix
  • Perf
  • Docs
  • Test
  • Chore
  • Style
  • Build
  • Feature
  • Refactor

SemVer

  • Fix (:label: Patch)
  • Feature (:label: Minor)
  • Breaking Change (:label: Major)

Checklist

  • Lint and unit tests pass with my changes
  • I have added tests that prove my fix is effective/works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes are merged and published in downstream modules

@ai
Copy link
Member

ai commented Nov 30, 2023

Wow. It was fast!

I will review it an hour later.

@brc-dd brc-dd changed the title feat: support loading esm and ts files from .jsonrc feat: support loading esm and ts files from json config Nov 30, 2023
src/plugins.js Outdated Show resolved Hide resolved
@ai ai merged commit 1928df0 into postcss:main Nov 30, 2023
3 checks passed
@ai
Copy link
Member

ai commented Nov 30, 2023

@brc-dd are we ready to release it?

BTW, I am planning to release all changes as major since we have too many internal changes.

@brc-dd
Copy link
Contributor Author

brc-dd commented Nov 30, 2023

Yeah good to go from my side. We'll update this at Vite side too and let you know how things pan out.

@ai
Copy link
Member

ai commented Dec 1, 2023

Released in 5.0. Thanks for the work. Ping me when it will be in Vite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants