Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dynamic imports on windows require file scheme #256

Merged
merged 1 commit into from Dec 4, 2023
Merged

fix: dynamic imports on windows require file scheme #256

merged 1 commit into from Dec 4, 2023

Conversation

brc-dd
Copy link
Contributor

@brc-dd brc-dd commented Dec 4, 2023

Notable Changes

Commit Message Summary (CHANGELOG)

Fixes v5 not working on Windows

Type

  • CI
  • Fix
  • Perf
  • Docs
  • Test
  • Chore
  • Style
  • Build
  • Feature
  • Refactor

SemVer

  • Fix (:label: Patch)
  • Feature (:label: Minor)
  • Breaking Change (:label: Major)

Issues

  • Fixes #1

Checklist

  • Lint and unit tests pass with my changes
  • I have added tests that prove my fix is effective/works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes are merged and published in downstream modules

@brc-dd
Copy link
Contributor Author

brc-dd commented Dec 4, 2023

/cc @ai

Can't seem to make the test runner work on windows CI, otherwise I'd have added that to matrix. Tested this with a patch in vite and it seems to be working fine after these changes - vitejs/vite#15235

@ai ai merged commit 54eb338 into postcss:main Dec 4, 2023
3 checks passed
@ai
Copy link
Member

ai commented Dec 4, 2023

Thanks. Released in 5.0.1.

@brc-dd brc-dd deleted the windows-fix branch December 4, 2023 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants