Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid using __require as a variable name #257

Merged
merged 1 commit into from Dec 4, 2023
Merged

fix: avoid using __require as a variable name #257

merged 1 commit into from Dec 4, 2023

Conversation

brc-dd
Copy link
Contributor

@brc-dd brc-dd commented Dec 4, 2023

Notable Changes

Looks like some projects are using __require for patching stuff like conditional imports. We can avoid naming the variable here to prevent conflicts.

Commit Message Summary (CHANGELOG)

avoid using __require as a variable name

Type

  • CI
  • Fix
  • Perf
  • Docs
  • Test
  • Chore
  • Style
  • Build
  • Feature
  • Refactor

SemVer

  • Fix (:label: Patch)
  • Feature (:label: Minor)
  • Breaking Change (:label: Major)

Issues

  • Fixes #1

Checklist

  • Lint and unit tests pass with my changes
  • I have added tests that prove my fix is effective/works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes are merged and published in downstream modules

@brc-dd brc-dd changed the title fix: use different name than __require fix: avoid using __require as a variable name Dec 4, 2023
@ai ai merged commit b619a08 into postcss:main Dec 4, 2023
3 checks passed
@ai
Copy link
Member

ai commented Dec 4, 2023

Do we need to release it?

@brc-dd
Copy link
Contributor Author

brc-dd commented Dec 4, 2023

yeah 😅

@ai
Copy link
Member

ai commented Dec 4, 2023

Sure. 5.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants