Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support loading config with tsx #260

Merged
merged 1 commit into from
May 1, 2024
Merged

Conversation

privatenumber
Copy link
Contributor

@privatenumber privatenumber commented May 1, 2024

Notable Changes

Commit Message Summary (CHANGELOG)

leverage tsx to load TypeScript & ESM config files

Type

  • Perf
  • Feature

SemVer

  • Feature (:label: Minor)

Issues

Follow up to #249

Checklist

  • Lint and unit tests pass with my changes
  • I have added tests that prove my fix is effective/works
  • I have added necessary documentation (if appropriate)

cc @brc-dd

"module": "Preserve",
"esModuleInterop": true,
"allowJs": true,
"noEmit": true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous settings were not type checking .js files

@ai
Copy link
Member

ai commented May 1, 2024

@brc-dd I remember that we spoke about tsx support for TS and for some reason decided that jiti is an only way. Do I remember it correctly?

@brc-dd
Copy link
Contributor

brc-dd commented May 1, 2024

Yeah. tsx added support for this today 😅 (privatenumber/tsx@42b7ede)

@privatenumber
Copy link
Contributor Author

Im also currently implementing a custom 'import()' with TypeScript support, so TLA would be supported too. But this would be limited to newer versions of Node that supports 'module.register()'.

@ai ai merged commit da69e94 into postcss:main May 1, 2024
3 checks passed
@ai
Copy link
Member

ai commented May 1, 2024

Thanks to everyone. Released in 5.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants