Handle root-level ampersands gracefully #153
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this inconsitent behavior in the plugin.
After thinking about this for a while, I feel that
postcss-nested
ought to handle this gracefully and treat a root-level&
selector token the same way it handles the empty selector — i.e. remove the curly block and replace all instances of&
with the empty string.(For comparison SASSMeister just errors on both of these cases, so... 🤷)
I ran into this in an actual project where we had mixin/function that got (quite reasonably) applied at the root level in certain cases, and the results felt surprisingly unelegant.
I've added these tests, but I'd be thankful if someone could provide/suggest the required changes in
index.js
.