Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test plugin order #97

Merged
merged 2 commits into from Mar 18, 2021
Merged

Test plugin order #97

merged 2 commits into from Mar 18, 2021

Conversation

sampullman
Copy link
Collaborator

@ai I started to work on #12, my first step was to include external plugins in the test suite. If you don't like this approach, I can just work on the error-check plugin and rely on basic testing.

I found that the plugin order for postcss-for is no longer an issue, I'm not sure why.

@sampullman sampullman requested a review from ai March 3, 2021 05:48
index.test.js Outdated Show resolved Hide resolved
@ai
Copy link
Member

ai commented Mar 5, 2021

PR with tests is my favorite type of PRs 😍

@sampullman
Copy link
Collaborator Author

Sorry for the delay, I've been way too busy. I reverted the style changes and added a test to check #98

@ai ai merged commit 897e6e2 into postcss:main Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants