lib/node.d.ts - Improved documentation #1846
Conversation
Improved documentation in lib/node.d.ts module.
Removed extra whitespace.
lib/node.d.ts
Outdated
| * The file source of the node. | ||
| * The source file from where a node has originated. | ||
| * | ||
| * @type {Input} |
There was a problem hiding this comment.
We do not need @type since it is already .d.ts file and types and written above: input: Input
lib/node.d.ts
Outdated
| * | ||
| * ```js | ||
| * root.nodes[0].parent === root | ||
| * console.log(root.nodes[0].parent === root); //=> true |
There was a problem hiding this comment.
Could you remove ;? Just to keep consistancy across docs.
There was a problem hiding this comment.
I was thinking to add semi-colon throughout the project...
lib/node.d.ts
Outdated
| * const prefixed = postcss.decl({ | ||
| * prop: '-moz-' + decl.prop, | ||
| * value: decl.value | ||
| * }) | ||
| * value: decl.value, |
There was a problem hiding this comment.
I think we should keep leading, it looks nice :Dz
I will make it consistent throughout the project.
|
Looks good! Congrats with the first PR! Just a few code style changes and we are ready to merge. |
Co-authored-by: Andrey Sitnik <andrey@sitnik.ru>
|
Still learning stuff, sorry for mistakes :) |
It is not a mistake, just my own code style preferences. Fix the |
|
understood, fixed all, please review :) |
|
Congrats! |
Hello, this is my first pull request!
Please review and accept if you like the documentation changes.
If this pull request gets accepted, I will improve documentation for the
whole Post CSS project.
I want to learn Post CSS better, so I have started by writing the documentation
for whole project.