Fixing issue #309 - References outside components and paths are not resolved #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@erfemega There are some conflicts that need resolution. Also, if you see |
- Referencing from out of components - Referencing paths from pathItems in oas 3.1 - Adding circular references in dereference process - Adding test scenarios
The method and implementation were changed to other location
erfemega
commented
Dec 12, 2022
erfemega
commented
Dec 12, 2022
LuisTejedaS
reviewed
Dec 14, 2022
LuisTejedaS
approved these changes
Dec 19, 2022
Carlos-Veloz
approved these changes
Dec 19, 2022
VShingala
reviewed
Dec 27, 2022
| * @returns {boolean} whether is circular reference or not. | ||
| */ | ||
| isCircularReference: function (traverseContext, contentFromTrace) { | ||
| return traverseContext.parents.find((parent) => { return parent.node === contentFromTrace; }) !== undefined; |
There was a problem hiding this comment.
@erfemega Is this a deep comparison?
|
Is there anything I can do to get this cleared out? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #309
It was added a suite of tests to validate that all referenceable elements:
are well resolved in both cases: