Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added nodejs typesript axios #343

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Abhirup-99
Copy link

Fixes #342

@Abhirup-99 Abhirup-99 changed the title added nodejs typesript axios [WIP]added nodejs typesript axios Sep 21, 2020
@Abhirup-99 Abhirup-99 changed the title [WIP]added nodejs typesript axios added nodejs typesript axios Sep 21, 2020
@Abhirup-99
Copy link
Author

the pr is ready for review.

Copy link
Contributor

@dhwaneetbhatt dhwaneetbhatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Abhirup-99 it would be better to pass an option to generate TypeScript code in the existing NodeJS-Axios generator rather than write an entirely new generator. Could you please update your fork with the latest changes from upstream and make the changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for typescript node js axios
3 participants