Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect multipart boundaries for plain HTTP #617

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

thinkgruen
Copy link

@thinkgruen thinkgruen commented May 3, 2022

Closes #616

Currently the same static value for boundary is set, but it should be different depending on where in the request it is located (beginning, as a separator and at the end).

To note:

  • I removed the last newline, because it seems unnecessary according to the standard, so the content-length changed by one or two, depending on whether or not the fixture was trimmed previously.

@thinkgruen thinkgruen force-pushed the fix/incorrect-boundaries-for-plain-http branch from 2f88394 to 126184e Compare May 3, 2022 20:14
Fixed linting

fixed looping
@thinkgruen thinkgruen force-pushed the fix/incorrect-boundaries-for-plain-http branch from 126184e to 375a8f5 Compare May 3, 2022 20:16
@thinkgruen thinkgruen changed the title Fixed implementation of multipart boundaries, adjusted test cases Fixed implementation of multipart boundaries in plain HTTP, adjusted test cases May 3, 2022
@thinkgruen thinkgruen changed the title Fixed implementation of multipart boundaries in plain HTTP, adjusted test cases Fix incorrect multipart boundaries for plain HTTP May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boundaries for multipart requests in plain HTTP are incorrect
1 participant