[FIX] cURL code snippet contains encoded value for special char + instead of char itself #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VShingala
requested changes
Apr 30, 2024
VShingala
reviewed
Apr 30, 2024
codegens/curl/lib/util.js
Outdated
| @@ -226,7 +226,8 @@ var self = module.exports = { | |||
| .replace(/%5D/g, ']') | |||
| .replace(/%7D/g, '}') | |||
| .replace(/%25/g, '%') | |||
| .replace(/'/g, '%27'); | |||
| .replace(/'/g, '%27') | |||
| .replace(/%2B/g, '+'); | |||
There was a problem hiding this comment.
@aman-v-singh Let's keep this at line no. 228. i.e. before we replace % chars.
|
I included this change in the test and it is passing 
|
VShingala
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
@aman-v-singh I think changes looks good. Let's make sure we test this behaviour in app as well before making a release.
|
@VShingala I added the fix for all the codegens along with tests. PS: here is the track with only curl changes. |
…ors into IMPORT-1337-c-url-code-snippet-contains-encoded-value-for-special-char-instead-of-char-itself
VShingala
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes issue where cURL snipet generated did not follow same behaviour as Postman Send request flow. i.e.
+character in query were being encoded, but ideally they should not be as it has a special meaning in query params. With this change, we'll make it so+is not encoded anymore.