Update tests to include callback in disconnect

postmanlabs · May 7, 2024 · 7415321 · 7415321
1 parent 9573c6e
commit 7415321
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 15 deletions.
diff --git a/test/unit/node/custom-sandbox.test.js b/test/unit/node/custom-sandbox.test.js
@@ -29,8 +29,7 @@
 
                 context.on('loopback', function (data) {
                     expect(data).to.equal('bar');
-                    context.disconnect();
-                    done();
+                    context.disconnect(done);
                 });
                 context.dispatch('loopback');
             });

diff --git a/test/unit/sanity.test.js b/test/unit/sanity.test.js
@@ -16,8 +16,7 @@ describe('uvm', function () {
         });
         vm.on('disconnect', () => {
             expect(loopbackData).to.eql([1, 2, 3, 4]);
-            vm.disconnect();
-            done();
+            vm.disconnect(done);
         });
 
         // dispatch before connect
@@ -162,20 +161,19 @@ describe('uvm', function () {
                 context.on('loopback', (data) => { loopbackData.push(data); });
                 context.on('disconnect', () => {
                     expect(loopbackData).to.eql([1, 2]);
-                    context.disconnect();
-                    done();
+                    context.disconnect(done);
                 });
 
                 context.dispatch('loopback', 1);
 
                 setTimeout(() => {
-                    context.disconnect();
-
-                    // reconnect
-                    context.connect({ bootCode }, (err) => {
-                        if (err) { return done(err); }
-                        context.dispatch('loopback', 2);
-                        context.dispatch('disconnect');
+                    context.disconnect(() => {
+                        // reconnect
+                        context.connect({ bootCode }, (err) => {
+                            if (err) { return done(err); }
+                            context.dispatch('loopback', 2);
+                            context.dispatch('disconnect');
+                        });
                     });
                 }, 100);
             });
@@ -186,8 +184,7 @@ describe('uvm', function () {
 
             vm.on('loopback', (data) => {
                 expect(data).to.equal('first');
-                vm.disconnect();
-                done();
+                vm.disconnect(done);
             });
 
             vm.connect({