chore(deps): update dependency vue to v3, @vue/test-utils to v2, and vuex to v4 #203
Conversation
winniehell
force-pushed
the
winniehell-major-vue-monorepo
branch
from
d28a352
to
659b938
Compare
package.json
Outdated
| "testEnvironmentOptions": { | ||
| "customExportConditions": ["node", "node-addons"] | ||
| } |
There was a problem hiding this comment.
|
@posva can you please review? |
Codecov Report
@@ Coverage Diff @@
## master #203 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 54 54
Branches 5 5
=========================================
Hits 54 54 |
|
I will but please don’t ping me each time you open a pull request because I already have the notification without the ping 😉 |
|
sure, sorry about that 👍 that is a habit I have developed at GitLab where merge requests or issues are generally not looked at if you don't ping people 🤷 |
this probably deserves to fixed prior to merging |
it looks like the corresponding code, namely Lines 77 to 84 in d7fc7b3 |
|
This would require to migrate vuex as well but it's impontant to keep the version working with Vue 2 so it's not something I can just merge. I will take a look when I have time |
|
I have cherry-picked the Vuex update and added a GitHub Actions workflow for the Vue 2 compatibilty. |
winniehell
changed the title
winniehell
force-pushed
the
winniehell-major-vue-monorepo
branch
from
46f7147
to
770b4f2
Compare
| ) | ||
| expect(() => { | ||
| // eslint-disable-next-line no-unused-expressions | ||
| wrapper.vm.a | ||
| }).toThrow(/module "nonExistent" not defined in state/) | ||
| }) | ||
| }) | ||
|
|
||
| onlyVue3('supports composition API', () => { |
There was a problem hiding this comment.
verifies that #185 is fixed
@posva do you have a rough estimate when that will be? I'm considering to release a temporary version from my fork to unblock https://gitlab.com/gitlab-org/gitlab/-/merge_requests/117107#note_1362089457 (which itself blocks a bugfix) |
|
Are you telling me the plugin already working with Vuex 4 and Vue 3? 😅 That's quite the surprise |
|
yes, looks like it does—and it was a surprise for me, too. 😃 I guess you did a great job on implementing this. 💪 |
posva
force-pushed
the
winniehell-major-vue-monorepo
branch
from
0c0dd9a
to
b986036
Compare
|
@posva thank you for merging this! ❤️ can I ask you to release a new version, too? you would do me a favor, if you choose to make it a 1.x release (because of the concern in https://gitlab.com/gitlab-org/gitlab/-/merge_requests/117107#note_1362056820). if you think that is not justified, can you please let me know what is missing? |
|
ah, I see, you have already released 0.1.0 🚀 |
supersedes #194, #197, and #201