Update request #4260
Update request #4260
Conversation
|
@nolanlawson is this something you can fix in throw-listeners? looks like if you handle 0 this should be good |
| @@ -1009,7 +1009,7 @@ function HttpPouch(opts, callback) { | |||
| headers: clone(host.headers), | |||
| method: 'POST', | |||
| url: genDBUrl(host, '_revs_diff'), | |||
| body: JSON.stringify(req) | |||
There was a problem hiding this comment.
Is this done by request now?
There was a problem hiding this comment.
Seems that way. In most cases strings weren't being passed, so these ones were out of the norm (as far as I could tell).
CouchDB was returning errors ("body must be valid JSON"), because request was seeming stringifying again (so an escaped string was being sent).
|
Yeah I can publish an update to that lib when there's a fix. |
|
|
|
Looks like one last issue with the map reduce tests |
|
Hmm alright. Different tests than I ran locally? About to have people over, but I'll take a look afterward. |
|
The map reduce tests are seperate, |
* give an explicit bump to throw-max-listeners-error to support the change as well
* give an explicit bump to throw-max-listeners-error to support the change as well
|
This is awesome, thanks :) - fc48a9b |
|
@daleharvey Great - thanks very much. Don't mean to be pushy or anything, wondering if there's an ETA for next release (v5.0.0 at this point?)? |
|
@omsmith We generally do monthly releases, so 1st of october |
|
Cool, thanks for the info |
Test failure due to nolanlawson/throw-max-listeners-error#1Such exciting things as working keep-alive in node > 0.10 request/request#1715