Support IPv6 addresses as hostnames #8509
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements a naive but fast pattern for matching an IPv6-style hostname, while preserving the original pattern for anything not matching IPv6.
|
Hello! Would you be able to add some tests? Thank you! |
|
@AlbaHerrerias I'll have time for this over the holiday before end of month. Does that fit with your overall plans? |
|
@aaronhuggins Sure! This PR won't make it to the release we're planning to do this week but it will for the next release, therefore I'm adding the |
|
we should probably rather switch to standard URI parsing APIs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a naive but fast pattern for matching an IPv6-style hostname, while preserving the original pattern for anything not matching IPv6.
This relates to a bug found by myself and @CanRau. For discussion of the bug, please see our twitter thread.
If you'd like me to add tests to specifically catch this issue and regressions in the future, please let me know and I'll add them.