Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update testing docs to match reality after #8569 #8940

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

janl
Copy link
Contributor

@janl janl commented Apr 28, 2024

No description provided.

@janl janl requested a review from alxndrsn April 28, 2024 14:46
Copy link
Contributor

@SourceR85 SourceR85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that easy on non-Debian based distros. (e.g. Fedora, Arch, RHEL, just to name a few other common distros)

Please add a link for others:
https://playwright.dev/docs/docker

Discussion and details can be found here:
microsoft/playwright#26482

@janl
Copy link
Contributor Author

janl commented Apr 29, 2024

Isn't that easy on non-Debian based distros. (e.g. Fedora, Arch, RHEL, just to name a few other common distros)

npx works everywhere. I just put into code what actually happens after we moved to playwright from selenium.

If you want to add additional documentation, feel free to push commits to this branch or open a new PR.

TESTING.md Show resolved Hide resolved

```shell
npx playwright install
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not sure this is the required command - ci is calling npx playwright install-deps:

steps:
- run: sudo npx playwright install-deps
shell: bash

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also does playwright already prompt for this or return a helpful error message if the dependencies aren't already available? If that's the case, I wouldn't bother duplicating that documentation here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants