Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bucket exists check before checking object exists while uploading image #610

Merged
merged 1 commit into from
May 8, 2024

Conversation

KeerthanaAP
Copy link
Contributor

Added bucket exists check before verifying whether the object exists when cos-instance-name is provided.

./pvsadm image upload -b power1-oss-bucket -f karthik-centos-8.ova.gz -n New-keer-cos -r us-south
I0507 22:46:33.462260   60503 upload.go:134] Bucket power1-oss-bucket not found in the instance New-keer-cos provided
I0507 22:46:35.949740   60503 upload.go:228] Creating a new bucket power1-oss-bucket
I0507 22:46:40.552761   60503 s3client.go:209] Waiting for bucket power1-oss-bucket to be created.
I0507 22:46:40.962257   60503 s3client.go:269] uploading the file karthik-centos-8.ova.gz

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 7, 2024
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KeerthanaAP, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 8, 2024
@ppc64le-cloud-bot ppc64le-cloud-bot merged commit 82510cb into ppc64le-cloud:main May 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants