New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add husky for pre commit hooks 🐶 #174
Open
idobetesh
wants to merge
16
commits into
main
Choose a base branch
from
Add_Husky_for_pre_commit_hooks
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
1b6ad9b
add husky
idobetesh 14c2afa
add ts prettier configurations
idobetesh 1c705e5
fix husky - can't be found
idobetesh eef6356
fix .git can't be found
idobetesh 0f0768a
fix
idobetesh 612ae6f
resolve conflicts
idobetesh aa714d4
check if git folder exits
idobetesh 7106f12
check if git folder exits one dir back
idobetesh cdb3baa
check if git folder exits one dir back into practica
idobetesh db75452
check if git folder exits one dir back into practica/husky
idobetesh 68f84aa
echo pwd
idobetesh 2ae102a
echo ls
idobetesh e75622f
echo ls two dirs back
idobetesh 93a7fbe
echo ls
idobetesh 03c3b40
stay on root
idobetesh 45f9769
reinstall
idobetesh File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ name: practica-quality-check | |
on: | ||
push: | ||
branches: | ||
- "*" | ||
- '*' | ||
pull_request: | ||
branches: [main] | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
#!/usr/bin/env sh | ||
. "$(dirname -- "$0")/_/husky.sh" | ||
|
||
npx pretty-quick --staged |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,15 @@ | ||
{} | ||
{ | ||
"arrowParens": "avoid", | ||
"bracketSpacing": true, | ||
"endOfLine": "lf", | ||
"bracketSameLine": false, | ||
"jsxSingleQuote": false, | ||
"printWidth": 80, | ||
"proseWrap": "preserve", | ||
"quoteProps": "as-needed", | ||
"semi": true, | ||
"singleQuote": true, | ||
"tabWidth": 2, | ||
"trailingComma": "all", | ||
"useTabs": false | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,16 @@ | ||
export type LOG_LEVELS = 'debug' | 'info' | 'warn' | 'error' | 'critical'; | ||
export type LOG_LEVELS = 'debug' | 'info' | 'warn' | 'error' | 'critical' | ||
|
||
export interface Logger { | ||
info(message: string, ...args: any[]): void; | ||
info(message: string, ...args: any[]): void | ||
|
||
error(message: string, ...args: any[]): void; | ||
error(message: string, ...args: any[]): void | ||
|
||
debug(message: string, ...args: any[]): void; | ||
debug(message: string, ...args: any[]): void | ||
|
||
warning(message: string, ...args: any[]): void; | ||
warning(message: string, ...args: any[]): void | ||
} | ||
|
||
export interface LoggerConfiguration{ | ||
level: LOG_LEVELS; | ||
prettyPrint: boolean; | ||
export interface LoggerConfiguration { | ||
level: LOG_LEVELS | ||
prettyPrint: boolean | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main selling point of Prettier is "Put aside your personal opinion, avoid team arguments, just use the industry standards that we've set". Should we really adjust its defaults?