Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: metric prefixes #472

Merged
merged 1 commit into from
May 9, 2024
Merged

Conversation

mertalev
Copy link
Contributor

@mertalev mertalev commented Mar 25, 2024

Description

This PR adds the ability to define custom prefixes for metrics. This prefix can be set for custom individual metrics, or for all API metrics. Host metrics are handled through an external dependency, so this is left for future work.

Fixes #265

@mertalev mertalev force-pushed the feat/prefixes branch 2 times, most recently from 44ab6ed to e7ca668 Compare March 25, 2024 00:40
@pragmaticivan
Copy link
Owner

Hi @mertalev
Thanks for sending this out, the code LGTM, but I might need you to rebase once more, would you mind?

Sorry about the really long delay, but I've been away from OS for a long break and hardly coding typescript in the past few months.

@mertalev
Copy link
Contributor Author

mertalev commented May 9, 2024

No worries! Thanks for coming back to it :)

@pragmaticivan
Copy link
Owner

Thanks!

@pragmaticivan pragmaticivan merged commit 4c047b8 into pragmaticivan:main May 9, 2024
3 checks passed
@mertalev mertalev deleted the feat/prefixes branch May 9, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to add Prefix to Metrics
2 participants