-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial work on rep * #24
base: 12-regex-ops
Are you sure you want to change the base?
Conversation
test/regex/zeroOrMore.test.js
Outdated
star [:k1 :k2] [:k1 :k2] nil | ||
star [:k1 :k2 "x"] ::s/invalid '[{:pred keyword?, :val "x" :via []}] | ||
star ["a"] ::s/invalid '[{:pred keyword?, :val "a" :via []}] | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just used the clojure tests as a starting point.
Changes Unknown when pulling a85864e on davidnormo:12-regex-ops into ** on prayerslayer:12-regex-ops**. |
Wow, thanks a lot for taking the time! It'll take a while until I can look over it thoroughly, possibly next Monday? I named As for what's missing, but you probably know this yourself, I'd like to see support for other specs (like map) and especially other combining specs like and/or as well as nilable. Do you think we can reuse your code to build |
Sure, I'm going try and tidy up a bit, so hopefully it's in a reasonable state for you to review. Yep, I need to add the other bits and pieces in (and/or etc). I'll have a think about |
I think I'm a bit closer, at least |
Changes Unknown when pulling 503ffda on davidnormo:12-regex-ops into ** on prayerslayer:12-regex-ops**. |
@prayerslayer So I've finally got kleene in a working state - will need a bit of clean up. I've found a couple of problems though:
|
That's what I tried to do until now, yes. Both have the semantic "value does not exist." But I'm open for arguments to change it, it might not hold well with nilable, repeatable things.
Could you provide a specific example? I'm not sure I follow. |
f680b4f
to
f3af629
Compare
Hello folks! any progress on this one? |
@arichiardi I've not had time to look at this and doubt I will in the near future. If that changes I'd love to help out more. Apologies! |
Just opening this PR now to get some feedback. A quick question: what name did you want to use for
*
- I'm leaning towardszeroOrMore
but that is quite verbose. There is alsorep
used in places andkleene
.Work in progress.