review feedback

pre-commit · Apr 4, 2021 · 6a5b7f7 · 6a5b7f7
1 parent bee802e
commit 6a5b7f7
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/pre_commit_hooks/check_case_conflict.py b/pre_commit_hooks/check_case_conflict.py
@@ -15,11 +15,10 @@ def lower_set(iterable: Iterable[str]) -> Set[str]:
 
 
 def parents(file: str) -> Iterator[str]:
-    while True:
-        file = os.path.dirname(file)
-        if not file:
-            return
+    file = os.path.dirname(file)
+    while file:
         yield file
+        file = os.path.dirname(file)
 
 
 def directories_for(files: Set[str]) -> Set[str]: