Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow any branch name in checks_vcs_permalinks #582

Merged
merged 1 commit into from Apr 7, 2021
Merged

Disallow any branch name in checks_vcs_permalinks #582

merged 1 commit into from Apr 7, 2021

Conversation

Jackenmen
Copy link
Contributor

Fixes #581

@asottile
Copy link
Member

asottile commented Apr 7, 2021

the title says "Allow", but specifically it's the opposite

@Jackenmen Jackenmen changed the title Allow any branch name in checks_vcs_permalinks Disallow any branch name in checks_vcs_permalinks Apr 7, 2021
asottile
asottile approved these changes Apr 7, 2021
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile asottile merged commit cfc3672 into pre-commit:master Apr 7, 2021
@Jackenmen Jackenmen deleted the allow_any_branch_name branch April 7, 2021 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asottile asottile asottile approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

check-vcs-permalinks - Add support for different branch names
2 participants
@Jackenmen @asottile