fixing the requirements-txt-fixer #960 #967
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @JaySharmaSdsu -- you'll need to add a test to demonstrate your changes -- you'll also need to make sure the current testsuite continues to work |
|
Hmm, interesting! Let me do that then! Will ping you if I need any help. Those pytest file look confusing as a newbie! |
|
hey @JaySharmaSdsu |
|
Hey @csibe17! Thank you for your patience! |
|
this ended up getting solved in #1014 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Anthony!
I have updated the requirements_txt_fixer.py to remove duplicate entries in the requirements file as per the bug in #960
Hope this helps!
Jay