Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update ForkTsCheckerWebpackPlugin which presented random lockin… #1818

Merged
merged 3 commits into from
Jan 27, 2024

Conversation

krskrs
Copy link

@krskrs krskrs commented Jan 27, 2024

update ForkTsCheckerWebpackPlugin which presented random locking issues with newest 4.x TS versions (fixes #1813 )

  • update ForkTsChecker configuration format
  • add ForkTsChecker plugin to the excluded plugins list of BabelEsmPlugin (the latter is directly calling apply on all the other plugins, causing unexpected behavior to ForkTsChecker)

…g issues with newest 4.x TS versions

* update ForkTsChecker configuration format
* add ForkTsChecker plugin to the excluded plugins list of BabelEsmPlugin (the latter is directly calling apply on all the other plugins, causing unexpected behavior to ForkTsChecker)
@krskrs krskrs requested a review from a team as a code owner January 27, 2024 11:15
Copy link

changeset-bot bot commented Jan 27, 2024

⚠️ No Changeset found

Latest commit: 4c66053

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rschristian
Copy link
Member

Sorry, going to close & reopen real quick to see if I can trigger the CI

@rschristian rschristian reopened this Jan 27, 2024
@rschristian
Copy link
Member

Thanks!

@rschristian rschristian merged commit 8db4257 into preactjs:3.x.x Jan 27, 2024
2 checks passed
@rschristian
Copy link
Member

Published as 3.5.1

@krskrs
Copy link
Author

krskrs commented Jan 27, 2024

Thank to you for considering my pull request. But are there some issues with tests? I looked at the test output here on github, but I couldn't clearly find what's exactly failing.

@rschristian
Copy link
Member

The tests for this PR passed, not sure what's up with the push to 3.x.x but it's probably nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants