Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add parent and children for useId #237

Merged
merged 9 commits into from Sep 10, 2022
Merged

add parent and children for useId #237

merged 9 commits into from Sep 10, 2022

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Aug 17, 2022

@changeset-bot
Copy link

changeset-bot bot commented Aug 17, 2022

🦋 Changeset detected

Latest commit: 6c898bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
preact-render-to-string Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JoviDeCroock JoviDeCroock deleted the use-id branch September 9, 2022 16:11
@JoviDeCroock JoviDeCroock restored the use-id branch September 9, 2022 16:11
@JoviDeCroock JoviDeCroock reopened this Sep 9, 2022
@JoviDeCroock JoviDeCroock changed the base branch from master to 5.2.3 September 9, 2022 16:12
Copy link
Member

@developit developit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now that this is perf-neutral.

@developit
Copy link
Member

... and now it's a performance improvement!

developit added a commit that referenced this pull request Sep 10, 2022
@JoviDeCroock JoviDeCroock changed the base branch from 5.2.3 to master September 10, 2022 19:16
@JoviDeCroock JoviDeCroock merged commit dec7a7a into master Sep 10, 2022
@JoviDeCroock JoviDeCroock deleted the use-id branch September 10, 2022 19:18
@github-actions github-actions bot mentioned this pull request Sep 10, 2022
developit added a commit that referenced this pull request Feb 2, 2023
… on #241 (#267)

* use index.module.js when benchmarking, since its the output of `npm run transpile`

* fix bench:v8 output path

* update microbundle and turn off function inlining

* fix JSX entrypoint and tests

* fix type defintion to reflect removed exports and options

* fix root copy of jsx types

* optimize renderToString performance using switch and short-circuiting

* Create bright-ligers-jam.md

* Update bright-ligers-jam.md

* Update bright-ligers-jam.md

* Backport changes from #237 (child/parent properties, simplified Fragment handling)

* ci: update github actions (#266)

* ci: update actions/checkout to v3

* ci: update actions/cache to v3

* merge master

* lockfile version

* update benchmarking reference implmementation to 5.2.6 (6a0bec2)

* fix tests

* fix before diff hook being called on invalid vnodes

* move non-exported files into a lib directory

* update pretty implementation and move typedefs into a d.ts

* Move chunked implementation out of the default entrypoint

* update tests to reflect chunking being moved out of default entrypoint

* fix d8 bench script

---------

Co-authored-by: Abdul Rauf <abdulraufmujahid@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants