Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix useId mismatch due to top level Fragments #248

Merged
merged 2 commits into from Oct 6, 2022
Merged

Conversation

marvinhagemeister
Copy link
Member

With preactjs/preact#3758 we need to include Fragments when setting masks. But core has an optimization where we flatten a Fragment when it's the top level node of the return value of a component.

function Foo() {
  // Will be flattened
  return <Fragment>...</Fragment>
}

@changeset-bot
Copy link

changeset-bot bot commented Oct 6, 2022

🦋 Changeset detected

Latest commit: 9ec2dc9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
preact-render-to-string Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@marvinhagemeister marvinhagemeister marked this pull request as ready for review October 6, 2022 19:05
@marvinhagemeister marvinhagemeister merged commit c2d7123 into master Oct 6, 2022
@marvinhagemeister marvinhagemeister deleted the vnode_mask2 branch October 6, 2022 19:07
@github-actions github-actions bot mentioned this pull request Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants