chore(compat): add package.json to exports #3755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compat/package.json
Outdated
Comment on lines
48
to
51
| "./package.json": { | ||
| "import": "./package.json", | ||
| "require": "./package.json" | ||
| } |
There was a problem hiding this comment.
This can be simplified a bit, since the formats do not differ. See the main package.json file:
Line 89 in 284a8b0
Suggested change
| "./package.json": { | |
| "import": "./package.json", | |
| "require": "./package.json" | |
| } | |
| "./package.json": "./package.json" |
There was a problem hiding this comment.
Thanks, makes sense!
marvinhagemeister
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When I switched from webpack aliasing react to preact, to doing it on package level in an Next.JS codebase I ran into a problem - storybook was throwing error - webpack was trying to access
package.json, but it wasn't defined in theexports.Adding this inside of
package.jsonhelped my case, but if this not is not how we should approach it, please guide me towards a better solution.