Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(compat): add package.json to exports #3755

Merged
merged 2 commits into from Oct 4, 2022
Merged

chore(compat): add package.json to exports #3755

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5d589c
chore(compat): add package.json to exports
akselander Oct 3, 2022
4362700
refactor(curb): remove format specifiers
akselander Oct 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions compat/package.json
View file
Open in desktop
Expand Up @@ -44,6 +44,10 @@
"./scheduler": {
"import": "./scheduler.mjs",
"require": "./scheduler.js"
},
"./package.json": {
"import": "./package.json",
"require": "./package.json"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be simplified a bit, since the formats do not differ. See the main package.json file:

preact/package.json

Line 89 in 284a8b0

"./package.json": "./package.json",

Suggested change
"./package.json": {
"import": "./package.json",
"require": "./package.json"
}
"./package.json": "./package.json"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, makes sense!

}
}