Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate ids when Fragments are involved #3758

Merged
merged 3 commits into from Oct 6, 2022
Merged

Conversation

marvinhagemeister
Copy link
Member

Marking as draft because this needs to be coordinated with render to string.

Fixes #3757

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

Size Change: -18 B (0%)

Total Size: 52.9 kB

Filename Size Change
hooks/dist/hooks.js 1.55 kB -8 B (0%)
hooks/dist/hooks.module.js 1.59 kB -1 B
hooks/dist/hooks.umd.js 1.64 kB -9 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.78 kB 0 B
compat/dist/compat.module.js 3.72 kB 0 B
compat/dist/compat.umd.js 3.85 kB 0 B
debug/dist/debug.js 3.01 kB 0 B
debug/dist/debug.module.js 3.01 kB 0 B
debug/dist/debug.umd.js 3.09 kB 0 B
devtools/dist/devtools.js 230 B 0 B
devtools/dist/devtools.module.js 239 B 0 B
devtools/dist/devtools.umd.js 314 B 0 B
dist/preact.js 4.04 kB 0 B
dist/preact.min.js 4.06 kB 0 B
dist/preact.min.module.js 4.05 kB 0 B
dist/preact.min.umd.js 4.08 kB 0 B
dist/preact.module.js 4.05 kB 0 B
dist/preact.umd.js 4.1 kB 0 B
jsx-runtime/dist/jsxRuntime.js 358 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 324 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 439 B 0 B
test-utils/dist/testUtils.js 442 B 0 B
test-utils/dist/testUtils.module.js 444 B 0 B
test-utils/dist/testUtils.umd.js 526 B 0 B

compressed-size-action

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.529% when pulling a08f182 on use-id-bug into b25fd03 on master.

@marvinhagemeister marvinhagemeister marked this pull request as ready for review October 6, 2022 19:24
@marvinhagemeister marvinhagemeister merged commit e968a5a into master Oct 6, 2022
@marvinhagemeister marvinhagemeister deleted the use-id-bug branch October 6, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicated useId values
3 participants