Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include HTML above render root for DOM validation #4043

Merged
merged 1 commit into from Jun 8, 2023

Conversation

marvinhagemeister
Copy link
Member

This fixes debug warnings when Islands are used where the preact tree is embedded into an existing HTML structure.

<table>
  <!-- preact renders here -->
</table>

Fixes denoland/fresh#1140

This fixes debug warnings when Islands are used where the preact
tree is embedded into an existing HTML structure
@coveralls
Copy link

Coverage Status

coverage: 99.708% (+0.003%) from 99.705% when pulling 2833c8e on table-validate into ac1f145 on master.

@github-actions
Copy link

github-actions bot commented Jun 8, 2023

Size Change: +258 B (0%)

Total Size: 56.5 kB

Filename Size Change
debug/dist/debug.js 3.64 kB +88 B (2%)
debug/dist/debug.module.js 3.62 kB +85 B (2%)
debug/dist/debug.umd.js 3.71 kB +85 B (2%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.92 kB 0 B
compat/dist/compat.module.js 3.84 kB 0 B
compat/dist/compat.umd.js 3.98 kB 0 B
devtools/dist/devtools.js 232 B 0 B
devtools/dist/devtools.module.js 240 B 0 B
devtools/dist/devtools.umd.js 315 B 0 B
dist/preact.js 4.26 kB 0 B
dist/preact.min.js 4.29 kB 0 B
dist/preact.min.module.js 4.29 kB 0 B
dist/preact.min.umd.js 4.32 kB 0 B
dist/preact.module.js 4.29 kB 0 B
dist/preact.umd.js 4.33 kB 0 B
hooks/dist/hooks.js 1.53 kB 0 B
hooks/dist/hooks.module.js 1.56 kB 0 B
hooks/dist/hooks.umd.js 1.62 kB 0 B
jsx-runtime/dist/jsxRuntime.js 360 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 326 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 441 B 0 B
test-utils/dist/testUtils.js 442 B 0 B
test-utils/dist/testUtils.module.js 444 B 0 B
test-utils/dist/testUtils.umd.js 526 B 0 B

compressed-size-action

@marvinhagemeister marvinhagemeister merged commit 841ef82 into master Jun 8, 2023
5 checks passed
@marvinhagemeister marvinhagemeister deleted the table-validate branch June 8, 2023 09:25
@JoviDeCroock JoviDeCroock mentioned this pull request Jul 8, 2023
@JoviDeCroock JoviDeCroock mentioned this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when an island returns a <tr/> component.
3 participants