Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 10 16 #4351

Merged
merged 11 commits into from Apr 27, 2024
Merged

Backport 10 16 #4351

merged 11 commits into from Apr 27, 2024

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Apr 26, 2024

Missing #4043 I tried implementing it but looks like _parent is missing on a lot of internals

Copy link

github-actions bot commented Apr 26, 2024

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: 75.22ms - 75.71ms
  • 03_update10th1k_x16: 32.02ms - 32.96ms
  • 07_create10k: 870.33ms - 890.59ms
  • filter_list: 123.29ms - 124.84ms
  • hydrate1k: 64.83ms - 69.43ms
  • many_updates: 110.25ms - 113.63ms
  • text_update: 29.93ms - 31.29ms
  • todo: 19.47ms - 19.61ms

usedJSHeapSize

  • 02_replace1k: 3.62ms - 3.62ms
  • 03_update10th1k_x16: 3.63ms - 3.64ms
  • 07_create10k: 26.25ms - 26.25ms
  • filter_list: 1.65ms - 1.65ms
  • hydrate1k: 13.72ms - 14.29ms
  • many_updates: 5.02ms - 5.02ms
  • text_update: 0.90ms - 0.90ms
  • todo: 0.93ms - 0.93ms

Results

02_replace1k

duration

VersionAvg timevs
75.22ms - 75.71ms-

usedJSHeapSize

VersionAvg timevs
3.62ms - 3.62ms-

run-warmup-0

VersionAvg timevs
26.67ms - 27.17ms-

run-warmup-1

VersionAvg timevs
28.87ms - 29.48ms-

run-warmup-2

VersionAvg timevs
28.19ms - 28.72ms-

run-final

VersionAvg timevs
75.23ms - 75.73ms-
03_update10th1k_x16

duration

VersionAvg timevs
32.02ms - 32.96ms-

usedJSHeapSize

VersionAvg timevs
3.63ms - 3.64ms-
07_create10k

duration

VersionAvg timevs
870.33ms - 890.59ms-

usedJSHeapSize

VersionAvg timevs
26.25ms - 26.25ms-
filter_list

duration

VersionAvg timevs
123.29ms - 124.84ms-

usedJSHeapSize

VersionAvg timevs
1.65ms - 1.65ms-
hydrate1k

duration

VersionAvg timevs
64.83ms - 69.43ms-

usedJSHeapSize

VersionAvg timevs
13.72ms - 14.29ms-
many_updates

duration

VersionAvg timevs
110.25ms - 113.63ms-

usedJSHeapSize

VersionAvg timevs
5.02ms - 5.02ms-
text_update

duration

VersionAvg timevs
29.93ms - 31.29ms-

usedJSHeapSize

VersionAvg timevs
0.90ms - 0.90ms-
todo

duration

VersionAvg timevs
19.47ms - 19.61ms-

usedJSHeapSize

VersionAvg timevs
0.93ms - 0.93ms-

tachometer-reporter-action v2 for Benchmarks

rerender();
expect(calls).to.deep.equal([
'removing ref from two',
'removing ref from three',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a change from main but in theory it is correct I think 😅 we move three and call the ref cleanup and ref again, would love verification on that though

Copy link

github-actions bot commented Apr 26, 2024

Size Change: -110 B (0%)

Total Size: 33.3 kB

Filename Size Change
dist/preact.js 4.64 kB -38 B (0%)
dist/preact.min.js 4.69 kB -43 B (0%)
dist/preact.umd.js 4.74 kB -49 B (1%)
test-utils/dist/testUtils.js 448 B +11 B (2%)
test-utils/dist/testUtils.umd.js 531 B +9 B (1%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.65 kB 0 B
compat/dist/compat.umd.js 3.73 kB 0 B
debug/dist/debug.js 3.23 kB 0 B
debug/dist/debug.umd.js 3.32 kB 0 B
devtools/dist/devtools.js 232 B 0 B
devtools/dist/devtools.umd.js 317 B 0 B
hooks/dist/hooks.js 1.52 kB 0 B
hooks/dist/hooks.umd.js 1.6 kB 0 B
jsx-runtime/dist/jsxRuntime.js 298 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 380 B 0 B

compressed-size-action

@coveralls
Copy link

coveralls commented Apr 27, 2024

Coverage Status

coverage: 99.19% (-0.1%) from 99.322%
when pulling 565532f on backport-10-16
into 255d011 on v11.

@JoviDeCroock JoviDeCroock merged commit a1f6a43 into v11 Apr 27, 2024
11 of 12 checks passed
@JoviDeCroock JoviDeCroock deleted the backport-10-16 branch April 27, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants