Adding better support for hooks related to time-slicing(concurrent) ⏲️
#3760
+47
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanjaiyan-dev
changed the title
sanjaiyan-dev
changed the title
time-slicing ⏲️
sanjaiyan-dev
changed the title
time-slicing ⏲️ time-slicing(concurrent) ⏲️
sanjaiyan-dev
changed the title
time-slicing(concurrent) ⏲️ time-slicing(concurrent) ⏲️
sanjaiyan-dev
changed the title
time-slicing(concurrent) ⏲️ time-slicing(concurrent) ⏲️
| return [false, startTransition]; | ||
| const [isTransitionPending, setIsTransitionPending] = useState(false); | ||
|
|
||
| const startTransitionFunction = (cb) => { |
There was a problem hiding this comment.
The function identity will change with every render. Let's find a way to keep the reference stable.
There was a problem hiding this comment.
using use callback have any effect on it ?
The function identity will change with every render. Let's find a way to keep the reference stable.
compat/src/index.js
Outdated
Comment on lines
37
to
46
| const requestIdleCallbackPreact = | ||
| (typeof self !== "undefined" && | ||
| self.requestIdleCallback && | ||
| self.requestIdleCallback.bind(window)) || | ||
| function (cb) { | ||
| return queueMicrotask(() => { | ||
| cb(); | ||
| }); | ||
| }; | ||
|
|
There was a problem hiding this comment.
I'm not sure if we need to bind the this value explicitly. Maybe we can simplify this a bit?
Suggested change
| const requestIdleCallbackPreact = | |
| (typeof self !== "undefined" && | |
| self.requestIdleCallback && | |
| self.requestIdleCallback.bind(window)) || | |
| function (cb) { | |
| return queueMicrotask(() => { | |
| cb(); | |
| }); | |
| }; | |
| const requestIdleCallbackPreact = | |
| typeof requestIdleCallback === 'function' | |
| ? requestIdleCallback | |
| : queueMicrotask; |
There was a problem hiding this comment.
Hi @marvinhagemeister , Currently i updated to setTimeout since it need to be cleared in unmount. (Can you please help me with it)
|
🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding better support for concurrency⏲️
Running the concurrent task in idle period using
window.requestIdleCallback.Extremely sorry if I made any mistakes :(