Add support for passing event options #3769
Draft
+421
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Tachometer Benchmark ResultsSummaryduration
usedJSHeapSize
Results02_replace1k
duration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
03_update10th1k_x16
duration
usedJSHeapSize
07_create10k
duration
usedJSHeapSize
filter_list
duration
usedJSHeapSize
hydrate1k
duration
usedJSHeapSize
many_updates
duration
usedJSHeapSize
text_update
duration
usedJSHeapSize
todo
duration
usedJSHeapSize
|
|
Size Change: +327 B (0%) Total Size: 53.4 kB
ℹ️ View Unchanged
|
| @@ -90,12 +90,17 @@ export function setProperty(dom, name, value, oldValue, isSvg) { | |||
| else name = name.slice(2); | |||
|
|
|||
| if (!dom._listeners) dom._listeners = {}; | |||
| if (!useCapture && Array.isArray(value)) { | |||
There was a problem hiding this comment.
What happens here when the user changes from passive to active? We would need to re-register the event-handler which might be unexpected that we aren't doing that. It did make me wonder whether the -capture would be a good fit for the -passive as well. The only other options are once and signal which I am not sure would fit here reliably....
There was a problem hiding this comment.
@JoviDeCroock According to MDN only the capture option is checked for matching event listeners. See: https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/removeEventListener#matching_event_listeners_for_removal
|
Marking as a draft, because browsers seems to turn scroll events into passive automatically in all browsers. Seems like the chrome DevTools warning is outdated? The passive option was the only reason going for implementing it. Leaving it here in case of future considerations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
touchstart,touchmoveandwheelhandlers passive by default, see: https://github.com/facebook/react/blob/main/packages/react-dom-bindings/src/events/DOMPluginEventSystem.js?rgh-link-date=2022-10-15T11%3A29%3A18Z#L432-L447Example:
Fixes #428 .