Merge master into v11 #3943
Open
Merge master into v11 #3943
+7,964
−25,687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jason Miller <developit@users.noreply.github.com>
implement state settling in X
…3562) * ensure both onchange and oninput callbacks are attached to the event listener * remove custom hook and combiner callbacks in one * update implementation and unit test * remove only on tests and improve error handling * cover scenario changing order * allow uncaught error in unit test * use event hook to trigger oncompatchange handler * use oninputCapture rather than oninput when both callbacks are defined Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>
* add export maps to the subpackages * format * run pretteir on package json files
…-input restrict "oninputCapture" conversion to just "oninput" vs "oninput*"
Function children that are passed as props to a component are still allowed but if that Component doesn't invoke the function and passes it a child, we'll skip over it.
📊 Tachometer Benchmark ResultsSummaryduration
usedJSHeapSize
Results02_replace1k
duration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-final
03_update10th1k_x16
duration
usedJSHeapSize
07_create10k
duration
usedJSHeapSize
filter_list
duration
usedJSHeapSize
hydrate1k
duration
usedJSHeapSize
many_updates
duration
usedJSHeapSize
text_update
duration
usedJSHeapSize
todo
duration
usedJSHeapSize
|
andrewiggins
requested review from
JoviDeCroock,
marvinhagemeister and
developit
|
Size Change: +778 B (2%) Total Size: 33.4 kB
ℹ️ View Unchanged
|
marvinhagemeister
approved these changes
Mar 21, 2023
andrewiggins
commented
Mar 21, 2023
| @@ -170,6 +170,29 @@ We closely watch our issues and have a pretty active [Slack workspace](https://c | |||
| This guide is intended for core team members that have the necessary | |||
| rights to publish new releases on npm. | |||
|
|
|||
| **TODO: Update instructions for v11 to include changesets** | |||
There was a problem hiding this comment.
At some future point we should update these instructions. I created a task in our project to track that.
| * Strict Mode is not implemented in Preact, so we provide a stand-in for it | ||
| * that just renders its children without imposing any restrictions. | ||
| */ | ||
| const StrictMode = Fragment; |
There was a problem hiding this comment.
Moved below flushSync to match master
Comment on lines
-146
to
-148
| function is(x, y) { | ||
| return (x === y && (x !== 0 || 1 / x === 1 / y)) || (x !== x && y !== y); | ||
| } |
There was a problem hiding this comment.
Moved to utils file to match master
| @@ -394,6 +398,32 @@ Component.prototype.setState = function(update, callback) { | |||
| return setState.call(this, update, callback); | |||
| }; | |||
|
|
|||
| /** @this {import('../../src/internal').Component} */ | |||
| Component.prototype.forceUpdate = function(callback) { | |||
There was a problem hiding this comment.
This check still exists in master so i've brought it back to keep them in-sync. For this change, I'd say we should do it in both or neither. I don't think this particular change (i.e. removing this earning) needs to be delayed for a major release.
Comment on lines
+131
to
+136
| // TODO: Required for RTS which currently doesn't set the `.data` property. | ||
| // Should we move this to RTS? | ||
| if (!currentInternal.data) { | ||
| currentInternal.data = {}; | ||
| } | ||
|
|
There was a problem hiding this comment.
Added a task to the project board for this
| @@ -303,6 +299,13 @@ function patchComponent(internal, newVNode) { | |||
| c.componentDidUpdate(oldProps, oldState, snapshot); | |||
| }); | |||
| } | |||
|
|
|||
| if (internal.data._stateCallbacks) { | |||
There was a problem hiding this comment.
@JoviDeCroock Is this move safe? All tests pass but it could use your eyes as well to double check. I moved it so state callbacks and componentDidUpdate are invoked in the same order as React and v10
|
Fix the benchmarks by manually setting debounceRendering to queueMicrotask so every version is batching using the same behavior and the numbers we are comparing are the same measurements in each version.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of good work has gone into v10 and I lost track of what changes have been cherry-picked into v11 and which ones still needed to be brought over so I did a full merge from master to v11. I think at one point we decided not to do full merges, but I figured since there has been a surge in work on v10, doing a full merge would ensure nothing was missed. I'll try to start doing these more regularly so that they are more approachable and things stay in sync.
Since this is a massive change, I'll try to summarize the significant changes and add comments in the PR for the interesting parts.
Changes:
useIdimplementationisStaticChildrento jsx-runtime packagesnullandundefinedto empty string when callingstyle.setPropertyundefinedto JSX types to support new TS option