Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an error in debug if NaN is in a hook's dependency array #3964

Merged
merged 1 commit into from
Apr 8, 2023

Conversation

andrewiggins
Copy link
Member

@andrewiggins andrewiggins commented Apr 7, 2023

Related #3954

@coveralls
Copy link

Coverage Status

Coverage: 99.706% (+0.005%) from 99.701% when pulling 049f382 on debug-NaN-hook-dep into 98af9bb on master.

@github-actions
Copy link

github-actions bot commented Apr 7, 2023

Size Change: +1.56 kB (2%)

Total Size: 56.3 kB

Filename Size Change
debug/dist/debug.js 3.53 kB +529 B (14%) ⚠️
debug/dist/debug.module.js 3.52 kB +515 B (14%) ⚠️
debug/dist/debug.umd.js 3.6 kB +516 B (14%) ⚠️
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 4.07 kB 0 B
compat/dist/compat.module.js 4 kB 0 B
compat/dist/compat.umd.js 4.13 kB 0 B
devtools/dist/devtools.js 232 B 0 B
devtools/dist/devtools.module.js 240 B 0 B
devtools/dist/devtools.umd.js 315 B 0 B
dist/preact.js 4.21 kB 0 B
dist/preact.min.js 4.24 kB 0 B
dist/preact.min.module.js 4.24 kB 0 B
dist/preact.min.umd.js 4.26 kB 0 B
dist/preact.module.js 4.23 kB 0 B
dist/preact.umd.js 4.27 kB 0 B
hooks/dist/hooks.js 1.53 kB 0 B
hooks/dist/hooks.module.js 1.56 kB 0 B
hooks/dist/hooks.umd.js 1.61 kB 0 B
jsx-runtime/dist/jsxRuntime.js 360 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 326 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 441 B 0 B
test-utils/dist/testUtils.js 442 B 0 B
test-utils/dist/testUtils.module.js 444 B 0 B
test-utils/dist/testUtils.umd.js 526 B 0 B

compressed-size-action

Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea! 🙌

@andrewiggins andrewiggins merged commit 90042a1 into master Apr 8, 2023
4 checks passed
@andrewiggins andrewiggins deleted the debug-NaN-hook-dep branch April 8, 2023 17:16
@JoviDeCroock JoviDeCroock mentioned this pull request May 13, 2023
JoviDeCroock added a commit that referenced this pull request Jan 22, 2024
JoviDeCroock added a commit that referenced this pull request Jan 23, 2024
* backport #3968

* backport #3964

* backport #3997

* backport #3995

* backport #3970

* backport #3971

* backport #3990

* backport #3963

* backport #3962

* backport #3960

* backport #3956

* Revert "backport #3963"

This reverts commit 86a372a.

* define public type

* fix newline issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants