Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update abb patch #3977

Open
wants to merge 2 commits into
base: abb
Choose a base branch
from
Open

update abb patch #3977

wants to merge 2 commits into from
+17 −3

Conversation

jpnelson
Copy link

No description provided.

@github-actions
Copy link

github-actions bot commented Apr 21, 2023 •
edited

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: faster ✔ 0% - 5% (0.42ms - 7.59ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -5% - +3% (-2.57ms - +1.96ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +1% (-4.96ms - +11.01ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -1% - +2% (-0.20ms - +0.37ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -1% - +4% (-1.67ms - +4.97ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -2% - +5% (-0.85ms - +1.88ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -2% - +4% (-0.08ms - +0.14ms)
    preact-local vs preact-master
  • todo: unsure 🔍 -3% - +1% (-2.12ms - +0.61ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -11% - +7% (-0.39ms - +0.25ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -2% - +5% (-0.32ms - +0.68ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - +1% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master148.13ms - 154.10ms-slower ❌
0% - 5%
0.42ms - 7.59ms		unsure 🔍
-4% - +2%
-6.47ms - +2.65ms
preact-local145.12ms - 149.10msfaster ✔
0% - 5%
0.42ms - 7.59ms		-faster ✔
1% - 6%
1.94ms - 9.90ms
preact-hooks149.58ms - 156.47msunsure 🔍
-2% - +4%
-2.65ms - +6.47ms		slower ❌
1% - 7%
1.94ms - 9.90ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master3.40ms - 3.90ms-unsure 🔍
-7% - +11%
-0.25ms - +0.39ms		unsure 🔍
-7% - +11%
-0.25ms - +0.38ms
preact-local3.37ms - 3.79msunsure 🔍
-11% - +7%
-0.39ms - +0.25ms		-unsure 🔍
-8% - +8%
-0.29ms - +0.28ms
preact-hooks3.39ms - 3.78msunsure 🔍
-10% - +7%
-0.38ms - +0.25ms		unsure 🔍
-8% - +8%
-0.28ms - +0.29ms		-

run-warmup-0

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master45.81ms - 47.34ms-unsure 🔍
-4% - +2%
-1.71ms - +0.99ms		faster ✔
1% - 6%
0.52ms - 2.83ms
preact-local45.83ms - 48.05msunsure 🔍
-2% - +4%
-0.99ms - +1.71ms		-unsure 🔍
-6% - +0%
-2.72ms - +0.10ms
preact-hooks47.39ms - 49.11msslower ❌
1% - 6%
0.52ms - 2.83ms		unsure 🔍
-0% - +6%
-0.10ms - +2.72ms		-

run-warmup-1

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master67.98ms - 70.68ms-faster ✔
1% - 7%
0.77ms - 4.95ms		unsure 🔍
-4% - +1%
-3.19ms - +0.90ms
preact-local70.60ms - 73.78msslower ❌
1% - 7%
0.77ms - 4.95ms		-unsure 🔍
-1% - +6%
-0.49ms - +3.93ms
preact-hooks68.94ms - 72.00msunsure 🔍
-1% - +5%
-0.90ms - +3.19ms		unsure 🔍
-5% - +1%
-3.93ms - +0.49ms		-

run-warmup-2

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master47.64ms - 51.60ms-unsure 🔍
-7% - +5%
-3.38ms - +2.71ms		unsure 🔍
-6% - +5%
-2.76ms - +2.61ms
preact-local47.63ms - 52.27msunsure 🔍
-5% - +7%
-2.71ms - +3.38ms		-unsure 🔍
-5% - +6%
-2.68ms - +3.20ms
preact-hooks47.88ms - 51.50msunsure 🔍
-5% - +6%
-2.61ms - +2.76ms		unsure 🔍
-6% - +5%
-3.20ms - +2.68ms		-

run-warmup-3

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master59.75ms - 64.46ms-unsure 🔍
-4% - +7%
-2.63ms - +4.08ms		unsure 🔍
-9% - +1%
-5.95ms - +0.92ms
preact-local58.99ms - 63.77msunsure 🔍
-7% - +4%
-4.08ms - +2.63ms		-unsure 🔍
-10% - +0%
-6.70ms - +0.21ms
preact-hooks62.12ms - 67.12msunsure 🔍
-2% - +10%
-0.92ms - +5.95ms		unsure 🔍
-0% - +11%
-0.21ms - +6.70ms		-

run-warmup-4

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master60.54ms - 63.93ms-unsure 🔍
-7% - +2%
-4.55ms - +1.15ms		unsure 🔍
-5% - +2%
-3.23ms - +1.59ms
preact-local61.64ms - 66.23msunsure 🔍
-2% - +7%
-1.15ms - +4.55ms		-unsure 🔍
-3% - +6%
-1.98ms - +3.74ms
preact-hooks61.34ms - 64.77msunsure 🔍
-3% - +5%
-1.59ms - +3.23ms		unsure 🔍
-6% - +3%
-3.74ms - +1.98ms		-

run-final

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master40.52ms - 45.27ms-slower ❌
1% - 17%
0.42ms - 6.46ms		unsure 🔍
-13% - +3%
-6.00ms - +1.30ms
preact-local37.59ms - 41.33msfaster ✔
1% - 15%
0.42ms - 6.46ms		-faster ✔
6% - 20%
2.44ms - 9.14ms
preact-hooks42.47ms - 48.03msunsure 🔍
-3% - +14%
-1.30ms - +6.00ms		slower ❌
6% - 24%
2.44ms - 9.14ms		-
03_update10th1k_x16

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master55.03ms - 58.71ms-unsure 🔍
-3% - +5%
-1.96ms - +2.57ms		unsure 🔍
-3% - +5%
-1.92ms - +2.65ms
preact-local55.24ms - 57.89msunsure 🔍
-5% - +3%
-2.57ms - +1.96ms		-unsure 🔍
-3% - +3%
-1.84ms - +1.96ms
preact-hooks55.15ms - 57.87msunsure 🔍
-5% - +3%
-2.65ms - +1.92ms		unsure 🔍
-3% - +3%
-1.96ms - +1.84ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master3.44ms - 3.45ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms		faster ✔
1% - 1%
0.02ms - 0.03ms
preact-local3.44ms - 3.45msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-faster ✔
0% - 1%
0.02ms - 0.02ms
preact-hooks3.46ms - 3.47msslower ❌
1% - 1%
0.02ms - 0.03ms		slower ❌
0% - 1%
0.02ms - 0.02ms		-
07_create10k

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1274.11ms - 1282.04ms-unsure 🔍
-1% - +0%
-11.01ms - +4.96ms		faster ✔
0% - 1%
0.31ms - 12.68ms
preact-local1274.17ms - 1288.03msunsure 🔍
-0% - +1%
-4.96ms - +11.01ms		-unsure 🔍
-1% - +0%
-11.87ms - +4.93ms
preact-hooks1279.83ms - 1289.31msslower ❌
0% - 1%
0.31ms - 12.68ms		unsure 🔍
-0% - +1%
-4.93ms - +11.87ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master25.36ms - 25.36ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
1% - 1%
0.18ms - 0.18ms
preact-local25.36ms - 25.36msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
1% - 1%
0.18ms - 0.18ms
preact-hooks25.53ms - 25.53msslower ❌
1% - 1%
0.18ms - 0.18ms		slower ❌
1% - 1%
0.18ms - 0.18ms		-
filter_list

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master21.92ms - 22.28ms-unsure 🔍
-2% - +1%
-0.37ms - +0.20ms		unsure 🔍
-3% - +1%
-0.61ms - +0.14ms
preact-local21.97ms - 22.41msunsure 🔍
-1% - +2%
-0.20ms - +0.37ms		-unsure 🔍
-2% - +1%
-0.55ms - +0.25ms
preact-hooks22.01ms - 22.67msunsure 🔍
-1% - +3%
-0.14ms - +0.61ms		unsure 🔍
-1% - +2%
-0.25ms - +0.55ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1.58ms - 1.58ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
1% - 1%
0.02ms - 0.02ms
preact-local1.58ms - 1.58msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
1% - 1%
0.02ms - 0.02ms
preact-hooks1.60ms - 1.60msslower ❌
1% - 1%
0.02ms - 0.02ms		slower ❌
1% - 1%
0.02ms - 0.02ms		-
hydrate1k

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master137.02ms - 141.89ms-unsure 🔍
-4% - +1%
-4.97ms - +1.67ms		unsure 🔍
-1% - +4%
-1.37ms - +5.30ms
preact-local138.85ms - 143.36msunsure 🔍
-1% - +4%
-1.67ms - +4.97ms		-slower ❌
0% - 5%
0.41ms - 6.82ms
preact-hooks135.21ms - 139.77msunsure 🔍
-4% - +1%
-5.30ms - +1.37ms		faster ✔
0% - 5%
0.41ms - 6.82ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master13.67ms - 14.35ms-unsure 🔍
-5% - +2%
-0.68ms - +0.32ms		unsure 🔍
-3% - +3%
-0.46ms - +0.48ms
preact-local13.82ms - 14.56msunsure 🔍
-2% - +5%
-0.32ms - +0.68ms		-unsure 🔍
-2% - +5%
-0.30ms - +0.68ms
preact-hooks13.67ms - 14.32msunsure 🔍
-3% - +3%
-0.48ms - +0.46ms		unsure 🔍
-5% - +2%
-0.68ms - +0.30ms		-
many_updates

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master34.57ms - 36.51ms-unsure 🔍
-5% - +2%
-1.88ms - +0.85ms		unsure 🔍
-4% - +4%
-1.48ms - +1.29ms
preact-local35.10ms - 37.02msunsure 🔍
-2% - +5%
-0.85ms - +1.88ms		-unsure 🔍
-3% - +5%
-0.95ms - +1.80ms
preact-hooks34.64ms - 36.62msunsure 🔍
-4% - +4%
-1.29ms - +1.48ms		unsure 🔍
-5% - +3%
-1.80ms - +0.95ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master4.63ms - 4.63ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-local4.63ms - 4.63msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-hooks4.65ms - 4.65msunsure 🔍
+0% - +0%
+0.02ms - +0.02ms		unsure 🔍
+0% - +0%
+0.02ms - +0.02ms		-
text_update

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master3.32ms - 3.47ms-unsure 🔍
-4% - +2%
-0.14ms - +0.08ms		faster ✔
2% - 9%
0.06ms - 0.33ms
preact-local3.35ms - 3.50msunsure 🔍
-2% - +4%
-0.08ms - +0.14ms		-faster ✔
1% - 8%
0.03ms - 0.30ms
preact-hooks3.48ms - 3.70msslower ❌
2% - 10%
0.06ms - 0.33ms		slower ❌
1% - 9%
0.03ms - 0.30ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master0.66ms - 0.66ms-unsure 🔍
-1% - +0%
-0.00ms - +0.00ms		faster ✔
21% - 21%
0.17ms - 0.17ms
preact-local0.66ms - 0.66msunsure 🔍
-0% - +1%
-0.00ms - +0.00ms		-faster ✔
20% - 21%
0.17ms - 0.17ms
preact-hooks0.83ms - 0.83msslower ❌
26% - 26%
0.17ms - 0.17ms		slower ❌
26% - 26%
0.17ms - 0.17ms		-
todo

duration

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master69.58ms - 71.42ms-unsure 🔍
-1% - +3%
-0.61ms - +2.12ms		unsure 🔍
-3% - +1%
-2.14ms - +0.65ms
preact-local68.74ms - 70.75msunsure 🔍
-3% - +1%
-2.12ms - +0.61ms		-faster ✔
0% - 4%
0.05ms - 2.95ms
preact-hooks70.20ms - 72.29msunsure 🔍
-1% - +3%
-0.65ms - +2.14ms		slower ❌
0% - 4%
0.05ms - 2.95ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-localvs preact-hooks
preact-master1.06ms - 1.06ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
2% - 2%
0.02ms - 0.02ms
preact-local1.06ms - 1.06msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
2% - 2%
0.02ms - 0.02ms
preact-hooks1.08ms - 1.08msslower ❌
2% - 2%
0.02ms - 0.02ms		slower ❌
2% - 2%
0.02ms - 0.02ms		-

tachometer-reporter-action v2 for Benchmarks

andrewiggins
andrewiggins reviewed Apr 21, 2023
View reviewed changes
src/create-context.js
Comment on lines +55 to +58
// Patch: this is a hot path, and taking sub out of the array is much
// faster this way since it's an unordered list.
subs[subs.indexOf(c)] = subs[subs.length - 1];
subs.pop();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also open a PR for against to master? Happy to do that as well if you are busy :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes for sure! #3979

developit
developit reviewed Apr 21, 2023
View reviewed changes
src/create-context.js
Comment on lines +57 to +58
subs[subs.indexOf(c)] = subs[subs.length - 1];
subs.pop();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if smaller/faster/slower:

Suggested change
subs[subs.indexOf(c)] = subs[subs.length - 1];
subs.pop();
subs[subs.indexOf(c)] = subs.pop();

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested it but I can't see how that'd be any different from having a separate assignment (maybe it'd even get minified to the same thing?) so that's the version I've put into the PR here: #3979

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this suggestion fails if you are removing the last item in the array

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed it does!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developit developit developit left review comments

@andrewiggins andrewiggins andrewiggins left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jpnelson @developit @andrewiggins