Fix debug tests #3980
Open
Fix debug tests #3980
+54
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvinhagemeister
requested review from
andrewiggins,
JoviDeCroock and
developit
📊 Tachometer Benchmark ResultsSummaryduration
usedJSHeapSize
Results02_replace1k
duration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-final
03_update10th1k_x16
duration
usedJSHeapSize
07_create10k
duration
usedJSHeapSize
filter_list
duration
usedJSHeapSize
hydrate1k
duration
usedJSHeapSize
many_updates
duration
usedJSHeapSize
text_update
duration
usedJSHeapSize
todo
duration
usedJSHeapSize
|
|
Size Change: +37 B (0%) Total Size: 38 kB
ℹ️ View Unchanged
|
andrewiggins
approved these changes
Apr 22, 2023
| vnode == null || | ||
| vnode === true || | ||
| vnode === false || | ||
| typeof vnode === 'function' |
There was a problem hiding this comment.
Should we do this typeof once and reuse it's result here and line 249?
Same for patch
There was a problem hiding this comment.
Just checked and storing the result in a variable is 10b larger. I think for now it's fine to leave it as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the debug tests and a few compat ones. Got the total failure count down to 5. The remaining failures are all for
forwardRefand it seems like we're puttingrefback in props at different stages for vnodes vs internals. Haven't found out why though, but I think the existing fixes are already worth PR'ing.