New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

type[compat]: add html attributes types #4099 #4100

Open

samsam-ahmadi wants to merge 5 commits into preactjs:main from samsam-ahmadi:compat-add-html-attributes-types

+560 −62

samsam-ahmadi commented Aug 15, 2023

This PR is for: #4099


          type[compat]: add html attributes types

7b364fb

rschristian reviewed

View reviewed changes

compat/src/index.d.ts Outdated Show resolved Hide resolved

rschristian reviewed

View reviewed changes

compat/src/index.d.ts Outdated Show resolved Hide resolved

samsam-ahmadi added 2 commits

August 16, 2023 08:46


          refactor: remove duplicate types

767e7ba


          extract the svg types and reexport them

1cc0de2

rschristian reviewed

View reviewed changes

src/jsx.d.ts Outdated Show resolved Hide resolved

rschristian reviewed

View reviewed changes

test-utils/src/index.js Outdated Show resolved Hide resolved

rschristian reviewed

View reviewed changes

test-utils/test/shared/act.test.js Outdated Show resolved Hide resolved

rschristian approved these changes

View reviewed changes

Member

rschristian left a comment

Looks very useful, thanks for doing this! We really appreciate it.

Might be nice to move the majority of these into core in the future, as I can see even non-compat users maybe wanting these, but that's an idea for another day.


          fix: update the name of type

f5840a6

samsam-ahmadi force-pushed the compat-add-html-attributes-types branch from c349cd9 to f5840a6 Compare

August 17, 2023 08:25


          Merge remote-tracking branch 'origin/main' into compat-add-html-attri…

9b1dafb

…butes-types

Author

samsam-ahmadi commented Aug 17, 2023

Thanks @rschristian,
I updated the branch and it's ready to merge.

Author

samsam-ahmadi commented Sep 1, 2023

Hi @rschristian, Any update for this one? How we can get the approval to can merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment