fix: Incorrect "missing transform-jsx-source" warning
#4350
+17
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Tachometer Benchmark ResultsSummaryduration
usedJSHeapSize
Resultscreate10k
duration
usedJSHeapSize
filter-list
duration
usedJSHeapSize
hydrate1k
duration
usedJSHeapSize
many-updates
duration
usedJSHeapSize
replace1k
duration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
text-update
duration
usedJSHeapSize
todo
duration
usedJSHeapSize
update10th1k
duration
usedJSHeapSize
|
|
Size Change: -5 B (0%) Total Size: 61 kB
ℹ️ View Unchanged
|
rschristian
commented
Apr 26, 2024
| console.warn( | ||
| 'Add @babel/plugin-transform-react-jsx-source to get a more detailed component stack. Note that you should not add it to production builds of your App for bundle size reasons.' | ||
| ); | ||
| } | ||
| showJsxSourcePluginWarning = false; |
There was a problem hiding this comment.
The idea being that at this point we've either seen .__source or printed the warning, and in either case, we're now covered. hasBabelPlugin previously would only ever be set to true once the warning was shown.
JoviDeCroock
approved these changes
Apr 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3818
The Preact-CLI usage from the issue is unfortunately borked and not fixable really: CLI has users export their root component which it (CLI) then renders using
h()-- no JSX source info is going to be added to that. That creates a situation in which there might not have been any vnodes with.__sourceset to flow through beforegetOwnerStack()is called.