Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport 10.17 #4352

Draft
wants to merge 4 commits into
base: v11
Choose a base branch
from
Draft

backport 10.17 #4352

wants to merge 4 commits into from

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Apr 27, 2024

Notes

Running into a lot of issues backporting #4088 because when we look up the dom in the parentInternal we basically run into the fact that we haven't reordered the parent children yet. I can make it behave a lot better by doing let nextSibling = getDomSibling({ _children: newChildren }, skewedIndex + 1); in children.js however that breaks a lot of other tests. The aforementioned issue might need a backport of the children algo split-up sooner where we first calculate the new _children array and then perform operations.

TODO:

@coveralls
Copy link

coveralls commented Apr 27, 2024

Coverage Status

coverage: 99.19%. remained the same
when pulling 6e37721 on backport-10-17
into a1f6a43 on v11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants