Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

major(core): use Set in create-context #4355

Open
wants to merge 1 commit into
base: breaking-changes-11
Choose a base branch
from

Conversation

JoviDeCroock
Copy link
Member

This improves perf, especially for deletion and breaks support with IE11

Copy link

github-actions bot commented Apr 29, 2024

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +1% (-11.73ms - +5.75ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -1% - +1% (-0.10ms - +0.16ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -3% - +1% (-2.25ms - +1.09ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -2% - +4% (-0.36ms - +0.77ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -2% - +2% (-1.58ms - +1.36ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -2% - +3% (-0.04ms - +0.05ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -2% - +4% (-0.48ms - +1.05ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -4% - +3% (-1.19ms - +0.89ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -4% - +1% (-0.65ms - +0.14ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - -0% (-0.01ms - -0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +1% (-0.01ms - +0.03ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -1% - +7% (-0.01ms - +0.08ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local892.92ms - 904.76ms-unsure 🔍
-1% - +1%
-11.73ms - +5.75ms
preact-main895.40ms - 908.26msunsure 🔍
-1% - +1%
-5.75ms - +11.73ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local26.75ms - 26.75ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-main26.75ms - 26.75msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.83ms - 17.01ms-unsure 🔍
-1% - +1%
-0.10ms - +0.16ms
preact-main16.80ms - 16.99msunsure 🔍
-1% - +1%
-0.16ms - +0.10ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.75ms - 1.75ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.75ms - 1.75msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local73.69ms - 74.67ms-unsure 🔍
-3% - +1%
-2.25ms - +1.09ms
preact-main73.17ms - 76.35msunsure 🔍
-1% - +3%
-1.09ms - +2.25ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local13.95ms - 14.44ms-unsure 🔍
-4% - +1%
-0.65ms - +0.14ms
preact-main14.14ms - 14.77msunsure 🔍
-1% - +5%
-0.14ms - +0.65ms
-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local17.15ms - 18.13ms-unsure 🔍
-2% - +4%
-0.36ms - +0.77ms
preact-main17.16ms - 17.71msunsure 🔍
-4% - +2%
-0.77ms - +0.36ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local4.86ms - 4.86ms-unsure 🔍
-0% - -0%
-0.01ms - -0.00ms
preact-main4.86ms - 4.87msunsure 🔍
+0% - +0%
+0.00ms - +0.01ms
-
replace1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local69.57ms - 71.22ms-unsure 🔍
-2% - +2%
-1.58ms - +1.36ms
preact-main69.29ms - 71.72msunsure 🔍
-2% - +2%
-1.36ms - +1.58ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.65ms - 3.68ms-unsure 🔍
-0% - +1%
-0.01ms - +0.03ms
preact-main3.65ms - 3.67msunsure 🔍
-1% - +0%
-0.03ms - +0.01ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local28.05ms - 28.71ms-unsure 🔍
-2% - +2%
-0.43ms - +0.58ms
preact-main27.92ms - 28.68msunsure 🔍
-2% - +2%
-0.58ms - +0.43ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local35.51ms - 37.41ms-unsure 🔍
-2% - +5%
-0.80ms - +1.87ms
preact-main35.00ms - 36.85msunsure 🔍
-5% - +2%
-1.87ms - +0.80ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local25.46ms - 26.00ms-unsure 🔍
-2% - +2%
-0.56ms - +0.48ms
preact-main25.33ms - 26.21msunsure 🔍
-2% - +2%
-0.48ms - +0.56ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local23.52ms - 24.45ms-unsure 🔍
-3% - +3%
-0.74ms - +0.64ms
preact-main23.52ms - 24.55msunsure 🔍
-3% - +3%
-0.64ms - +0.74ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local29.71ms - 31.38ms-unsure 🔍
-5% - +3%
-1.49ms - +0.81ms
preact-main30.10ms - 31.67msunsure 🔍
-3% - +5%
-0.81ms - +1.49ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local23.43ms - 24.51ms-unsure 🔍
-3% - +4%
-0.63ms - +0.92ms
preact-main23.27ms - 24.37msunsure 🔍
-4% - +3%
-0.92ms - +0.63ms
-
text-update

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.70ms - 1.77ms-unsure 🔍
-2% - +3%
-0.04ms - +0.05ms
preact-main1.70ms - 1.76msunsure 🔍
-3% - +2%
-0.05ms - +0.04ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.18ms - 1.24ms-unsure 🔍
-1% - +7%
-0.01ms - +0.08ms
preact-main1.15ms - 1.21msunsure 🔍
-6% - +1%
-0.08ms - +0.01ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local27.61ms - 28.92ms-unsure 🔍
-2% - +4%
-0.48ms - +1.05ms
preact-main27.59ms - 28.37msunsure 🔍
-4% - +2%
-1.05ms - +0.48ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.25ms - 1.25ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-main1.25ms - 1.25msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms
-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local32.39ms - 33.67ms-unsure 🔍
-4% - +3%
-1.19ms - +0.89ms
preact-main32.36ms - 34.00msunsure 🔍
-3% - +4%
-0.89ms - +1.19ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.69ms - 3.69ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-main3.69ms - 3.69msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms
-

tachometer-reporter-action v2 for Benchmarks

Copy link

Size Change: +4 B (0%)

Total Size: 61.1 kB

Filename Size Change
dist/preact.js 4.61 kB +1 B
dist/preact.module.js 4.62 kB +3 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 4.09 kB 0 B
compat/dist/compat.module.js 4.01 kB 0 B
compat/dist/compat.umd.js 4.14 kB 0 B
debug/dist/debug.js 3.63 kB 0 B
debug/dist/debug.module.js 3.63 kB 0 B
debug/dist/debug.umd.js 3.71 kB 0 B
devtools/dist/devtools.js 230 B 0 B
devtools/dist/devtools.module.js 239 B 0 B
devtools/dist/devtools.umd.js 314 B 0 B
dist/preact.min.js 4.64 kB 0 B
dist/preact.min.module.js 4.64 kB 0 B
dist/preact.min.umd.js 4.67 kB 0 B
dist/preact.umd.js 4.68 kB 0 B
hooks/dist/hooks.js 1.55 kB 0 B
hooks/dist/hooks.module.js 1.59 kB 0 B
hooks/dist/hooks.umd.js 1.63 kB 0 B
jsx-runtime/dist/jsxRuntime.js 976 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 949 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 1.06 kB 0 B
test-utils/dist/testUtils.js 453 B 0 B
test-utils/dist/testUtils.module.js 454 B 0 B
test-utils/dist/testUtils.umd.js 536 B 0 B

compressed-size-action

@coveralls
Copy link

Coverage Status

coverage: 99.609%. remained the same
when pulling 50ac9ad on use-set-in-create-context
into 613cacc on main.

@coveralls
Copy link

Coverage Status

coverage: 99.609%. remained the same
when pulling 50ac9ad on use-set-in-create-context
into 613cacc on main.

@JoviDeCroock JoviDeCroock changed the base branch from main to breaking-changes-11 April 30, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants