Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support vite 3 #49

Closed
IanVS opened this issue Jun 22, 2022 · 2 comments
Closed

Support vite 3 #49

IanVS opened this issue Jun 22, 2022 · 2 comments

Comments

@IanVS
Copy link

IanVS commented Jun 22, 2022

Hi, I attempted to update a storybook vite example to vite 3 beta, and found that our preact example is failing.

I've created a minimal reproduction at https://github.com/IanVS/vitejs-vite-ccuzee.

Besides the peerDependencies needing an update, I get an error when running a built app (dev works fine). The error is:

Uncaught ReferenceError: require is not defined

Which comes from an attempted require("preact").

@JoviDeCroock
Copy link
Member

Odd, I would have assumed vite to use the import or module build which does not use require https://www.runpkg.com/?@preact/preset-vite@2.2.0/dist/esm/index.mjs

@IanVS
Copy link
Author

IanVS commented Jun 22, 2022

This seems to be a duplicate of #52.

@IanVS IanVS closed this as completed Jun 22, 2022
@IanVS IanVS closed this as not planned Won't fix, can't repro, duplicate, stale Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants