fix: support vite v3 #50
Merged
+1
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm that this change fixes the issue I was having in the storybook preact example (#49). |
|
Hi @JoviDeCroock, vite 3 is close to being released out of beta soon, do you think you might have a chance to review this PR, to avoid users having problems with preact? |
|
Apologies, been really busy lately. Did y'all have a chance to test this already, I can make some time to test it out as well later tonight. We want it to work with both vite 2 and 3 so will test both, there must be a reason why we had thsi code |
|
Tested with both vite 2 as well as 3 worked fine! |
|
Thanks! |
Merged
|
Thank you very much for your work! |
Interpause
pushed a commit
to Interpause/preact-preset-vite
that referenced
this pull request
Aug 7, 2022
Interpause
pushed a commit
to Interpause/preact-preset-vite
that referenced
this pull request
Aug 7, 2022
JoviDeCroock
added a commit
that referenced
this pull request
Oct 13, 2023
* allow jsx import source to be configured * allow package to be installed via git * fix: support vite v3 (#50) * 2.3.0 (#53) * add named export to improve `"module": "nodenext"` compatibility (#48) * add named export to improve `"module": "nodenext"` compatibility * add proper types export * Update src/index.ts Co-authored-by: Jovi De Croock <decroockjovi@gmail.com> Co-authored-by: Jovi De Croock <decroockjovi@gmail.com> * Update package.json * remove "prepare" script --------- Co-authored-by: 翠 / green <green@sapphi.red> Co-authored-by: Jovi De Croock <decroockjovi@gmail.com> Co-authored-by: Volodymyr Zhdanov <wight554@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preact provides
exportsfield andmodulefield so it worked without interop codes.This PR removes them because it was causing issues with Vite v3.
fixes #52
I tested with Vite (3.0.0-beta.1, 2.9.12) and preact (10.8.2, 10.7.0) with reproduction on #49.