Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure stack-trace works w/ CJS build #116

Merged
merged 1 commit into from Mar 19, 2024
Merged

fix: Ensure stack-trace works w/ CJS build #116

merged 1 commit into from Mar 19, 2024

Conversation

rschristian
Copy link
Member

Closes #115

stack-trace is shipped exclusively as ESM, so this switches to importing via dynamic import to fix CJS consumers.

@rschristian rschristian merged commit aef0301 into main Mar 19, 2024
1 check passed
@rschristian rschristian deleted the fix/cjs-stack-trace branch March 19, 2024 06:57
@marvinhagemeister
Copy link
Member

@rschristian FYI I made a stack trace parsing library a while back for Preact DevTools for the hook detection part. It should work too https://www.npmjs.com/package/errorstacks

@rschristian
Copy link
Member Author

Oh nice, didn't know.

Any advantage over stack-trace (beyond maybe CJS support)?

@marvinhagemeister
Copy link
Member

errorstacks works for other engines too, not just v8. But that probably doesn't matter here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when updating to v2.8.2
3 participants
@rschristian @marvinhagemeister @JoviDeCroock