add named export to improve "module": "nodenext" compatibility
#48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wight554
commented
May 25, 2022
wight554
commented
- see Losing types when importing cjs module using default export with nodenext modules microsoft/TypeScript#48845
|
Any progress on this one @JoviDeCroock ? |
Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>
JoviDeCroock
approved these changes
Jul 16, 2022
Interpause
pushed a commit
to Interpause/preact-preset-vite
that referenced
this pull request
Aug 7, 2022
…actjs#48) * add named export to improve `"module": "nodenext"` compatibility * add proper types export * Update src/index.ts Co-authored-by: Jovi De Croock <decroockjovi@gmail.com> Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>
Interpause
pushed a commit
to Interpause/preact-preset-vite
that referenced
this pull request
Aug 7, 2022
…actjs#48) * add named export to improve `"module": "nodenext"` compatibility * add proper types export * Update src/index.ts Co-authored-by: Jovi De Croock <decroockjovi@gmail.com> Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>
|
Any reason this change has not been released? Doesn't seem like a breaking change. |
|
No, not a particular reason, this somehow went through the cracks between all the notifications. |
JoviDeCroock
added a commit
that referenced
this pull request
Oct 13, 2023
* allow jsx import source to be configured * allow package to be installed via git * fix: support vite v3 (#50) * 2.3.0 (#53) * add named export to improve `"module": "nodenext"` compatibility (#48) * add named export to improve `"module": "nodenext"` compatibility * add proper types export * Update src/index.ts Co-authored-by: Jovi De Croock <decroockjovi@gmail.com> Co-authored-by: Jovi De Croock <decroockjovi@gmail.com> * Update package.json * remove "prepare" script --------- Co-authored-by: 翠 / green <green@sapphi.red> Co-authored-by: Jovi De Croock <decroockjovi@gmail.com> Co-authored-by: Volodymyr Zhdanov <wight554@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.