Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preciso: updates docs for new fields #5191

Merged
merged 23 commits into from
Jun 10, 2024
Merged

Conversation

PrecisoSRL
Copy link
Contributor

@PrecisoSRL PrecisoSRL commented Mar 7, 2024

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

Copy link

netlify bot commented Mar 7, 2024

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 7c7e303
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/661772b17b5c5b0008cc136d
😎 Deploy Preview https://deploy-preview-5191--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there are releated pull requested? Or have you documented features that you are not actually providing?

dev-docs/bidders/preciso.md Outdated Show resolved Hide resolved
dev-docs/bidders/preciso.md Show resolved Hide resolved
@PrecisoSRL
Copy link
Contributor Author

Is there are releated pull requested? Or have you documented features that you are not actually providing?

Hi @muuki88 , we have already created a PR (prebid/Prebid.js#11161) with the latest changes we have made. Sorry for not mentioning the PR earlier.

dev-docs/bidders/preciso.md Outdated Show resolved Hide resolved
dev-docs/bidders/preciso.md Outdated Show resolved Hide resolved
dev-docs/bidders/preciso.md Outdated Show resolved Hide resolved
dev-docs/bidders/preciso.md Outdated Show resolved Hide resolved
@PrecisoSRL PrecisoSRL requested a review from muuki88 April 8, 2024 09:35
@muuki88 muuki88 added the LGTM label Apr 8, 2024
@PrecisoSRL PrecisoSRL requested a review from muuki88 June 10, 2024 05:56
@muuki88 muuki88 merged commit c3fe0f5 into prebid:master Jun 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants