Skip to content

Commit

Permalink
Added fix for building node 10
Browse files Browse the repository at this point in the history
  • Loading branch information
mathiask88 committed Nov 18, 2020
1 parent f1f29ea commit 0866ef9
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions index.js
Expand Up @@ -189,6 +189,9 @@ function build (target, runtime, opts, cb) {
if (runtime === 'electron') {
args.push('--runtime=electron')
args.push('--dist-url=https://atom.io/download/electron')
} else if (runtime === 'node') {
// work around bug introduced in node 10's build https://github.com/nodejs/node-gyp/issues/1457
args.push('--build_v8_with_gn=false')
}

if (opts.debug) {
Expand Down

0 comments on commit 0866ef9

Please sign in to comment.